fix: env variables #185
Merged
fix: env variables #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Review failedThe pull request is closed. WalkthroughThe recent changes across the files primarily focus on enhancing flexibility and clarity in the authentication logic. The updates include making certain parameters optional, improving error messaging, and refining the construction of Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client Application
participant ARC as AppRouterClient
participant PRC as PagesRouterClient
rect rgb(200, 200, 255)
note over ARC, PRC: New Redirect URL Logic
Client ->> ARC: Initialize with options
alt options?.config?.siteUrl exists
ARC ->> ARC: Set redirectURL to `${options?.config?.siteUrl}/api/auth/kinde_callback`
else
ARC ->> ARC: Set redirectURL to config.clientOptions.redirectURL
end
Client ->> PRC: Initialize with options
alt options?.config?.siteUrl exists
PRC ->> PRC: Set redirectURL to `${options?.config?.siteUrl}/api/auth/kinde_callback`
else
PRC ->> PRC: Set redirectURL to config.clientOptions.redirectURL
end
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
Suppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.